Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Restore changes from PR #127 overwritten by PR #138 #154

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

simmsa
Copy link
Contributor

@simmsa simmsa commented Dec 19, 2024

PR #138's merge inadvertently overwrote WDRT module updates from PR #127
due to an incorrect merge conflict resolution here: simmsa@a0d07da

…iT-Software#138

PR MHKiT-Software#138's merge inadvertently overwrote WDRT module updates from PR#127
due to an incorrect merge conflict resolution here: a0d07da
@simmsa simmsa marked this pull request as ready for review December 19, 2024 17:19
@simmsa simmsa requested a review from hivanov-nrel December 19, 2024 17:19
@simmsa
Copy link
Contributor Author

simmsa commented Dec 19, 2024

@hivanov-nrel this is good to go. I verified that the Loads_TestExtreme tests pass on my local machine.

Copy link
Contributor

@hivanov-nrel hivanov-nrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, im hoping that it doesnt cause merge conflicts with my most recent PR, but we'll make it work!

@simmsa
Copy link
Contributor Author

simmsa commented Dec 19, 2024

Thank you! Yes, hopefully there are no merge conflicts!

@simmsa simmsa merged commit 0352446 into MHKiT-Software:develop Dec 19, 2024
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants