-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOLfYN: Add dimensional averaging, current speed/direction calculations, and enhance ADCP example #141
Conversation
The previous code here appeared to use an xarray features that allow for comparison across coordinates/dimensions. This more explicitly creates a matrix of ranges over time and outputs bds as a binary matrix with 1 denoting a value below the surface interference distance and 0 a value above the surface interference distance.
Add `plotArgs` argument allowing the user to passing arguments directly to the selected plotting function
* Extract titles and labels from dataset where possible * Add subplots via dimension array argument * Add color bar limits * Specify colors for specific fields * Add "kind", histogram only for now * Improve code readability
This improves the speed of `read_signature` by caching the result instead of performing the conversion. Testing on `accp_example` gives a roughly 10% improvement speed read speed.
Remove older `.h5` writer in favor of `ncreate`, `ncwrite`, and `ncwriteatt`. NetCDF support in MATLAB seems to have improved significantly compared to the 2021 releases.
Includes all python features except turbulence statistics
@simmsa I have a few tests failing - screenshots below. I am looking into it, but let me know if you have seen these before. |
@rpauly18 thank you. Those failing tests look familiar, can you try the code from here: https://github.com/simmsa/MHKiT-MATLAB/tree/dolfyn-parity?
Those tests are fixed in develop and I merged them into this pr here: simmsa@486f817 to avoid any merge conflicts and can see changes the dolfyn-parity branch above, but I do not see the changes in this PR. LMK if this doesn't work. |
Overview
dolfyn_plot
for consistent visualizationsDetails
.m
file foracdp_example.m
dolfyn_plot
kind
py_struct_2_bytes_format
for better performancewrite_netcdf
for MATLAB 2022+ compatibilityFunction Renaming to Match MHKiT-Python Conventions
find_surface_from_P
→water_depth_from_pressure
nan_beyond_surface
→remove_surface_interference
These renames align our function names with MHKiT-Python conventions for better consistency across the ecosystem.
Testing
read_netcdf