-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add method
option to surface_elevation
#126
Add method
option to surface_elevation
#126
Conversation
`method` allows the user to choose between using the `ifft` or `sum_of_sines` method for calculation of the surface elevation. See <MHKiT-Software/MHKiT-Python#250> where this was implemented in MHKiT-Python.
Actions MATLAB does not currently work on arm images of macos
List of changes:
|
@rpauly18 or @hivanov-nrel, this is ready for review when either of you have time. I would like to get this into master before we merge Delft3D functionality. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Andrew, from a technical standpoint, this looks fine. Some of the tests are failing on my local machine which was trying to resolve before approving, but since they are passing in GitHub, it's probably something in my local MHKiT Matlab install.
In MHKiT-Python #250 a method option was added to
wave.resource.surface_elevation
. This exposes that option to the MHKiT-MATLAB user.