Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method option to surface_elevation #126

Merged
merged 7 commits into from
May 10, 2024

Conversation

simmsa
Copy link
Contributor

@simmsa simmsa commented Apr 22, 2024

In MHKiT-Python #250 a method option was added to wave.resource.surface_elevation. This exposes that option to the MHKiT-MATLAB user.

simmsa added 3 commits April 22, 2024 15:54
`method` allows the user to choose between using the `ifft` or
`sum_of_sines` method for calculation of the surface elevation.

See <MHKiT-Software/MHKiT-Python#250> where this
was implemented in MHKiT-Python.
@simmsa simmsa marked this pull request as ready for review April 29, 2024 20:01
@simmsa simmsa requested review from rpauly18 and hivanov-nrel April 29, 2024 20:02
@simmsa
Copy link
Contributor Author

simmsa commented Apr 29, 2024

List of changes:

  1. Add method option to surface elevation
  2. Add test to to verify that the method option gets passed to python and the results for each method match each other
  3. Get tests working using findings from delft-3d-io branch
  4. Update plugin version to 0.4.1.1
  5. Update binary

@simmsa
Copy link
Contributor Author

simmsa commented May 6, 2024

@rpauly18 or @hivanov-nrel, this is ready for review when either of you have time. I would like to get this into master before we merge Delft3D functionality.

Copy link
Contributor

@rpauly18 rpauly18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Andrew, from a technical standpoint, this looks fine. Some of the tests are failing on my local machine which was trying to resolve before approving, but since they are passing in GitHub, it's probably something in my local MHKiT Matlab install.

@simmsa
Copy link
Contributor Author

simmsa commented May 10, 2024

@rpauly18, thanks for reviewing! The new version of MHKiT-Python is introducing some new bugs for us. I am tracking them in #130. My best guess is your test failures are related similar to the ones introduced by v0.8.0. I am going to go ahead and merge this.

@simmsa simmsa merged commit 5889ff0 into MHKiT-Software:master May 10, 2024
43 checks passed
@simmsa simmsa mentioned this pull request Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants