Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/improve decodable configuration #8

Merged
merged 5 commits into from
Jun 2, 2023

Conversation

roanutil
Copy link
Member

@roanutil roanutil commented Jun 2, 2023

  • Improve API for configuring decoder for Option and OptionSet
  • Add OptionDecodingTests and OptionSetDecodingTests
  • Add helpers for easily adding decode configuration to a decoder's user info dictionary for Option and OptionSet
  • Add remaining helpers for configuring a decoder for Option and OptionSet decoding

roanutil added 4 commits May 23, 2023 22:58
feature/improve-decodable-configuration
feature/improve-decodable-configuration
…r info dictionary for Option and OptionSet

feature/improve-decodable-configuration
…Set decoding

feature/improve-decodable-configuration
@roanutil roanutil temporarily deployed to default June 2, 2023 18:21 — with GitHub Actions Inactive
@roanutil roanutil temporarily deployed to default June 2, 2023 18:21 — with GitHub Actions Inactive
@roanutil roanutil temporarily deployed to default June 2, 2023 18:21 — with GitHub Actions Inactive
@roanutil roanutil temporarily deployed to default June 2, 2023 18:21 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Merging #8 (38bdd47) into main (faa43b0) will increase coverage by 4.27%.
The diff coverage is 80.24%.

@@            Coverage Diff             @@
##             main       #8      +/-   ##
==========================================
+ Coverage   77.07%   81.34%   +4.27%     
==========================================
  Files          19       23       +4     
  Lines        1339     1410      +71     
==========================================
+ Hits         1032     1147     +115     
+ Misses        307      263      -44     
Impacted Files Coverage Δ
...gumentEncoding/DecoderUserInfo+OptionHelpers.swift 50.00% <50.00%> (ø)
...entEncoding/DecoderUserInfo+OptionSetHelpers.swift 53.33% <53.33%> (ø)
Sources/ArgumentEncoding/Option.swift 60.41% <100.00%> (+16.96%) ⬆️
Sources/ArgumentEncoding/OptionSet.swift 63.63% <100.00%> (+31.20%) ⬆️
...ts/ArgumentEncodingTests/OptionDecodingTests.swift 100.00% <100.00%> (ø)
...ArgumentEncodingTests/OptionSetDecodingTests.swift 100.00% <100.00%> (ø)

@roanutil roanutil temporarily deployed to default June 2, 2023 21:02 — with GitHub Actions Inactive
@roanutil roanutil temporarily deployed to default June 2, 2023 21:02 — with GitHub Actions Inactive
@roanutil roanutil temporarily deployed to default June 2, 2023 21:02 — with GitHub Actions Inactive
@roanutil roanutil temporarily deployed to default June 2, 2023 21:02 — with GitHub Actions Inactive
@roanutil roanutil merged commit 787941b into main Jun 2, 2023
@roanutil roanutil deleted the feature/improve-decodable-configuration branch June 2, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants