Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plots #105

Merged
merged 20 commits into from
May 9, 2024
Merged

plots #105

merged 20 commits into from
May 9, 2024

Conversation

orionarcher
Copy link
Collaborator

@orionarcher orionarcher commented May 8, 2024

Description

This PR adds new plotting functionality and cleans up internal naming conventions.

Solves issue #30.

Todos

Notable points that this PR has either accomplished or will accomplish.

  • Change "count" column to "fraction" in speciation, better representing its meaning
  • Add compare_networking, compare_coordination_vs_random, plot_speciation, and plot_rdfs
  • Migrate remaining matplotlib plots to plotly
  • Change x_axis keyword in plots to x_axis_solute and make it a bool
  • Update basic tutorial to show new solvation plot
  • Add new plot types to plotting tutorial
  • Add plot visuals to landing page and readme to better advertise capabilities

Status

  • Ready to go

@pep8speaks
Copy link

pep8speaks commented May 8, 2024

Hello @orionarcher! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-05-09 23:30:27 UTC

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@orionarcher orionarcher merged commit c9957d6 into main May 9, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants