-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #2692 #2694
Fix #2692 #2694
Conversation
Thanks for working on this, @RMeli! I mentioned earlier that I thought something similar to seaborn's FacetGrid.set_titles function could be a way to address this -- Seaborn makes the variables |
Thanks @lilyminium , I'll have a look. I messed up branches in this PR, so I'll keep it on hold until #2685 is merged. |
Codecov Report
@@ Coverage Diff @@
## develop #2694 +/- ##
========================================
Coverage 91.22% 91.23%
========================================
Files 176 176
Lines 24082 24084 +2
Branches 3155 3156 +1
========================================
+ Hits 21970 21972 +2
Misses 1489 1489
Partials 623 623
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but for the frame remark thing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you @RMeli!
Co-authored-by: Lily Wang <[email protected]>
I added your suggestion and solved the conflicts. Should be good to go. @lilyminium I'll have a look at your suggestion for enhanced string formatting once 1.0 is out. |
Sounds good :-) |
Fixes #2692
Changes made in this Pull Request:
remark
inXYZWriter
PR Checklist