Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove format from MemoryReader.timeseries #2567

Merged
merged 3 commits into from
Feb 29, 2020
Merged

Remove format from MemoryReader.timeseries #2567

merged 3 commits into from
Feb 29, 2020

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Feb 29, 2020

Towards v1.0 #2443
Completes #1453 for MemoryReader

Changes made in this Pull Request:

  • Removes support for the deprecated format keyword in :meth:MemoryReader.timseries.

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@codecov
Copy link

codecov bot commented Feb 29, 2020 •
edited
Loading

Codecov Report

Merging #2567 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2567   +/-   ##
========================================
  Coverage    90.69%   90.69%           
========================================
  Files          170      170           
  Lines        22857    22857           
  Branches      2943     2943           
========================================
  Hits         20730    20730           
  Misses        1540     1540           
  Partials       587      587

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7bdc61...e3212f5. Read the comment docs.

orbeckst
orbeckst requested changes Feb 29, 2020
View reviewed changes
Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only one comment on the docs. Thanks for doing all these important house-keeping PRs!

package/MDAnalysis/coordinates/memory.py Show resolved Hide resolved
@orbeckst orbeckst self-assigned this Feb 29, 2020
@orbeckst orbeckst merged commit 9bcf6f4 into MDAnalysis:develop Feb 29, 2020
@IAlibay IAlibay deleted the memory-format branch February 29, 2020 22:48
lilyminium pushed a commit to lilyminium/mdanalysis that referenced this pull request Mar 4, 2020
@IAlibay @lilyminium
Remove deprecated format from MemoryReader.timeseries (MDAnalysis#2567)
d7aaf1b 
* Completes MDAnalysis#1453 for MemoryReader (and towards v1.0 MDAnalysis#2443)
* Removes support for the deprecated format keyword in MemoryReader.timeseries.
* Removes deprecation test
* Update CHANGELOG
@fiona-naughton fiona-naughton added maintainability deprecation Deprecated functionality to give advance warning for API changes. labels Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orbeckst orbeckst orbeckst approved these changes

Assignees

@orbeckst orbeckst

Labels
deprecation Deprecated functionality to give advance warning for API changes. maintainability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IAlibay @orbeckst @fiona-naughton