Fixed entity rotations #2596
Merged
Fixed entity rotations #2596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed entity yaw and pitch not changing when entity moves head.
4 tasks
MinecraftClient/McClient.cs
Outdated
Comment on lines
3166
to
3167
| entities[EntityID].Yaw = _yaw * (1F / 256) * 360; | ||
| entities[EntityID].Pitch = _pitch * (1F / 256) * 360; |
There was a problem hiding this comment.
The yaw and pitch calculation should be done in Protocol18 before passing to handler so that:
- Client handler don't need to care about protocol (e.g. how to convert the
byteback to yaw and pitch) - If there's some update to the protocol (data type or calculation change), client handler can remain untouched
ReinforceZwei
requested changes
Oct 9, 2023
MinecraftClient/McClient.cs
Outdated
| @@ -3168,6 +3184,16 @@ public void OnEntityPosition(int EntityID, Double Dx, Double Dy, Double Dz, bool | |||
|
|
|||
| } | |||
|
|
|||
| public void OnEntityRotation(int EntityID, byte _yaw, byte _pitch, bool onGround) | |||
There was a problem hiding this comment.
Add method document comment.
| @@ -195,6 +195,8 @@ public void UpdateInternal() | |||
| /// <param name="entity">Entity with updated location</param> | |||
| public virtual void OnEntityMove(Entity entity) { } | |||
|
|
|||
| public virtual void OnEntityRotate(Entity entity) { } | |||
| void OnEntityPosition(int entityID, Double dx, Double dy, Double dz, bool onGround); | ||
| void OnEntityRotation(int entityID, byte yaw, byte pitch, bool onGround); |
ReinforceZwei
approved these changes
Oct 11, 2023
|
Good job. Thanks for your work. Merging your PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed entity yaw and pitch not changing when an entity/player moves their head.