Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ShiftRightClick #2582

Merged
merged 14 commits into from
Sep 16, 2023
Merged

Added ShiftRightClick #2582

merged 14 commits into from
Sep 16, 2023

Conversation

ozi2285
Copy link
Contributor

@ozi2285 ozi2285 commented Sep 15, 2023

Just Added ShiftRightClick to MCC Because When User Need it on Server They Play, They Can Use it.

Copy link
Member

@ReinforceZwei ReinforceZwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. Great job, just some minor change and we can merge your work.

MinecraftClient/Commands/Inventory.cs Outdated Show resolved Hide resolved
MinecraftClient/Protocol/Handlers/Protocol18.cs Outdated Show resolved Hide resolved
MinecraftClient/McClient.cs Outdated Show resolved Hide resolved
@@ -2426,7 +2426,15 @@ internal class Translations {
return ResourceManager.GetString("cmd.inventory.shiftclick", resourceCulture);
}
}


internal static string cmd_inventory_shiftrightclick //shiftrightclick translations link
Copy link
Member

@ReinforceZwei ReinforceZwei Sep 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to use Visual Studio to add a new translation string instead of directly modifying source. I'll do that for you when I have time, or you can try it out yourself.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well i didn't know about how this one work so can i leave it to you?

Copy link
Member

@ReinforceZwei ReinforceZwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution again. Merging your PR.

@ReinforceZwei ReinforceZwei merged commit 968f864 into MCCTeam:master Sep 16, 2023
@ozi2285
Copy link
Contributor Author

ozi2285 commented Sep 16, 2023

Thanks. When New Release Gonna Happen?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants