Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Netcdf improvements #5

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Netcdf improvements #5

wants to merge 14 commits into from

Conversation

matthewhoffman
Copy link

This PR includes a series of modifications needed to get netcdf input and output working correctly. Those commits are based on top of a previous branch of Holly's, and we may want to separate out these branches.

hollyhan and others added 14 commits March 13, 2023 14:53
@hollyhan
Add global mean-level calculations
ad2b3be
@hollyhan
calculate gmsle in/outside of the mali domain (for debug)
4882768
@hollyhan
change ice density to 910 kg/m^3
c9de1ca
@hollyhan
change the sphere radius of the Earth
e74fe74
@hollyhan
add back the option patch_ice
73b2f38 
also add the area calculation for the ice-model domain
@hollyhan
patch zero ice thickness everywhere
8ad20d9 
regardless of the mali mask
@hollyhan
change the radius of the Earth and calculate and exchange k^2 with MALI
b716325
@matthewhoffman
Have netcdf input print a message of the file it is reading
cdac4a7
@matthewhoffman
Change way tgrid0 is read in to avoid netcdf input error
011296c
@matthewhoffman
protect read of mali_mask_init inside check for coupling
e9da9ba 
This allows non-coupling runs to proceed without needing that file
@matthewhoffman
flip lat array in output netcdf files
fc30ccf 
This is needed for them to be displayed right side up in ncview,
which presumably is interpreting array layout correctly.
Add option to run elastic only calculation
ff92fcb
Adjust Makefile to build with netcdf on Mac
11216d6 
We used netcdf from conda!
Added "sl_sphharm" option which allows you to output delta SL in sphe…
b7cfe40 
…rical harmonics as a textfile. The name of this textfile is hardcoded.
@hollyhan
Copy link
Collaborator

hollyhan commented Oct 3, 2023

Thanks for creating this PR, @matthewhoffman!
As you commented above, would you mind separating out the commits from me, you and @SophieCoulson?
I want to go head with merging the commits made by @SophieCoulson for running elastic calculation first, and wait to merge the netcdf improvement-related commit until we figure the latitude-orientiation issue to the bottom of it hopefully soon.

@matthewhoffman
Copy link
Author

@hollyhan , sorry this has sat for so long. Let me know if you still want to separate this PR into pieces.

@hollyhan
Copy link
Collaborator

hollyhan commented Feb 1, 2024

@matthewhoffman
Thanks for following up with this PR! I think we can just take out the commit fc30ccf from this PR and merge everything. The mentioned commit is on flipping the latitude array in netcdf output, which I found to be not needed and warrants more investigation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthewhoffman @hollyhan