Fix #393

MAIF · Nov 12, 2019 · 3162ec6 · 3162ec6
1 parent 5114e08
commit 3162ec6
Show file tree

Hide file tree

Showing 5 changed files with 18 additions and 3 deletions.
diff --git a/otoroshi/app/env/Env.scala b/otoroshi/app/env/Env.scala
@@ -550,7 +550,8 @@ class Env(val configuration: Configuration,
     removeHeadersOut = Seq.empty,
     accessValidator = AccessValidatorRef(),
     missingOnlyHeadersIn = Map.empty,
-    missingOnlyHeadersOut = Map.empty
+    missingOnlyHeadersOut = Map.empty,
+    stripPath = true
   )
 
   lazy val otoroshiVersion     = "1.4.14-dev"

diff --git a/otoroshi/app/gateway/handlers.scala b/otoroshi/app/gateway/handlers.scala
@@ -1108,6 +1108,7 @@ class GatewayRequestHandler(snowMonkey: SnowMonkey,
                                       val uriParts = rawUri.split("/").toSeq
                                       val uri: String =
                                         descriptor.matchingRoot
+                                          .filter(_ => descriptor.stripPath)
                                           .map(m => req.relativeUri.replace(m, ""))
                                           .getOrElse(rawUri)
                                       val scheme =

diff --git a/otoroshi/app/gateway/websockets.scala b/otoroshi/app/gateway/websockets.scala
@@ -622,7 +622,10 @@ class WebSocketHandler()(implicit env: Env) {
                                 val rawUri   = req.relativeUri.substring(1)
                                 val uriParts = rawUri.split("/").toSeq
                                 val uri: String =
-                                  descriptor.matchingRoot.map(m => req.relativeUri.replace(m, "")).getOrElse(rawUri)
+                                        descriptor.matchingRoot
+                                          .filter(_ => descriptor.stripPath)
+                                          .map(m => req.relativeUri.replace(m, ""))
+                                          .getOrElse(rawUri)
                                 // val index = reqCounter.incrementAndGet() % (if (descriptor.targets.nonEmpty) descriptor.targets.size else 1)
                                 // // Round robin loadbalancing is happening here !!!!!
                                 // val target = descriptor.targets.apply(index.toInt)

diff --git a/otoroshi/app/models/descriptor.scala b/otoroshi/app/models/descriptor.scala
@@ -1780,6 +1780,7 @@ case class ServiceDescriptor(
     targets: Seq[Target] = Seq.empty[Target],
     root: String = "/",
     matchingRoot: Option[String] = None,
+    stripPath: Boolean = true,
     localHost: String = "localhost:8080",
     localScheme: String = "http",
     redirectToLocal: Boolean = false,
@@ -2309,6 +2310,7 @@ object ServiceDescriptor {
           localScheme = (json \ "localScheme").asOpt[String].getOrElse("http"),
           redirectToLocal = (json \ "redirectToLocal").asOpt[Boolean].getOrElse(false),
           enabled = (json \ "enabled").asOpt[Boolean].getOrElse(true),
+          stripPath = (json \ "stripPath").asOpt[Boolean].getOrElse(true),
           userFacing = (json \ "userFacing").asOpt[Boolean].getOrElse(false),
           privateApp = (json \ "privateApp").asOpt[Boolean].getOrElse(false),
           forceHttps = (json \ "forceHttps").asOpt[Boolean].getOrElse(true),
@@ -2416,6 +2418,7 @@ object ServiceDescriptor {
       "targets"                    -> JsArray(sd.targets.map(_.toJson)),
       "root"                       -> sd.root,
       "matchingRoot"               -> sd.matchingRoot,
+      "stripPath"                  -> sd.stripPath,
       "localHost"                  -> sd.localHost,
       "localScheme"                -> sd.localScheme,
       "redirectToLocal"            -> sd.redirectToLocal,
@@ -2520,7 +2523,8 @@ trait ServiceDescriptorDataStore extends BasicStore[ServiceDescriptor] {
       removeHeadersOut = Seq.empty,
       accessValidator = AccessValidatorRef(),
       missingOnlyHeadersIn = Map.empty,
-      missingOnlyHeadersOut = Map.empty
+      missingOnlyHeadersOut = Map.empty,
+      stripPath = true
     )
   def updateMetrics(id: String,
                     callDuration: Long,

diff --git a/otoroshi/javascript/src/pages/ServicePage.js b/otoroshi/javascript/src/pages/ServicePage.js
@@ -1187,6 +1187,12 @@ export class ServicePage extends Component {
                   .matchingRoot || ''}/`}
               />
             )}
+            <BooleanInput 
+              label="Strip path"
+              value={this.state.service.stripPath}
+              help="When matching, strip the matching prefix from the upstream request URL. Defaults to true"
+              onChange={e => this.changeTheValue('stripPath', e)}
+            />
           </Collapse>
           <Collapse
             notVisible={this.state.service.tcpUdpTunneling}