-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI updates #24
base: develop
Are you sure you want to change the base?
UI updates #24
Conversation
marjo-luc
commented
Dec 3, 2024
•
edited
Loading
edited
- added 'view jobs' button on submit job page
- added 'view jobs' button in toast after job submission
- added job duration column to jobs overview table
- refactored filtering toolbar
- disabled 'reset filters' button when filters are not shown
- refresh button pulled to the right of the ui
- 'submit new job' button moved to the top of the ui
- changed styling of tabs in job details panel
- updated the split panel controls to be less painful to use
- job cancel button/action toolbar removed from overview table
- job cancel button pushed to individual job context (shows only when a job is cancel-able)
- cleaned up NaN values for job duration for incomplete jobs
- fixed select column filtering bug
yes I think this approach to status is okay (dropdown) and avoids the state bug |
Workspace in which these changes are deployed: mas.dit.maap-project.org/root/maap-workspaces/jupyterlab/python:ui-updates |
1 similar comment
Not sure why the font is mismatched, but I can fix that and change the button color. I don't want to focus on styling issues too much, though, as we have a ticket to overhaul styling of these extensions in the next milestone, so this will be moot. |
maybe we can just make it a (solid) blue button? what other buttons are red in our UI? |
I'm fine with either -- @grallewellyn ? |
The cancel job square was red before. I would think we want the cancel job button to stand out a little more so users don't accidentally cancel jobs |
I don't mind trying it, especially as it's only shown for active jobs. I think the red makes it the juiciest click-target on the page though :D If we find ppl are pressing it by accident, we can also add a confirmation dialog |
Okay, I would be okay with making it blue |