Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI updates #24

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from
Open

UI updates #24

wants to merge 15 commits into from

Conversation

marjo-luc
Copy link
Member

@marjo-luc marjo-luc commented Dec 3, 2024

  • added 'view jobs' button on submit job page
  • added 'view jobs' button in toast after job submission
  • added job duration column to jobs overview table
  • refactored filtering toolbar
  • disabled 'reset filters' button when filters are not shown
  • refresh button pulled to the right of the ui
  • 'submit new job' button moved to the top of the ui
  • changed styling of tabs in job details panel
  • updated the split panel controls to be less painful to use
  • job cancel button/action toolbar removed from overview table
  • job cancel button pushed to individual job context (shows only when a job is cancel-able)
  • cleaned up NaN values for job duration for incomplete jobs
  • fixed select column filtering bug

@marjo-luc marjo-luc changed the title Feature/UI updates UI updates Dec 3, 2024
@rtapella
Copy link

yes I think this approach to status is okay (dropdown) and avoids the state bug

@marjo-luc marjo-luc marked this pull request as ready for review January 16, 2025 01:14
@marjo-luc
Copy link
Member Author

Workspace in which these changes are deployed: mas.dit.maap-project.org/root/maap-workspaces/jupyterlab/python:ui-updates

@grallewellyn
Copy link
Collaborator

  1. Could we make these the same fonts?
Screenshot 2025-01-16 at 12 14 25 PM 2. I don't think the cancel job button is very obvious. Maybe we could make it red?

I tested every bullet you had listed above too and it works for me

1 similar comment
@grallewellyn
Copy link
Collaborator

  1. Could we make these the same fonts?
Screenshot 2025-01-16 at 12 14 25 PM 2. I don't think the cancel job button is very obvious. Maybe we could make it red?

I tested every bullet you had listed above too and it works for me

@marjo-luc
Copy link
Member Author

Not sure why the font is mismatched, but I can fix that and change the button color. I don't want to focus on styling issues too much, though, as we have a ticket to overhaul styling of these extensions in the next milestone, so this will be moot.

@rtapella
Copy link

rtapella commented Jan 16, 2025

maybe we can just make it a (solid) blue button? what other buttons are red in our UI?

@marjo-luc
Copy link
Member Author

marjo-luc commented Jan 16, 2025

I'm fine with either -- @grallewellyn ?

@grallewellyn
Copy link
Collaborator

The cancel job square was red before. I would think we want the cancel job button to stand out a little more so users don't accidentally cancel jobs

@rtapella
Copy link

I don't mind trying it, especially as it's only shown for active jobs. I think the red makes it the juiciest click-target on the page though :D

If we find ppl are pressing it by accident, we can also add a confirmation dialog

@grallewellyn
Copy link
Collaborator

Okay, I would be okay with making it blue
That would still make it more obvious

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants