Deny wrong pull (go-gitea#13308)

* Deny wrong pull * Update routers/api/v1/repo/pull.go Co-authored-by: zeripath <[email protected]> Co-authored-by: Markus <[email protected]> Co-authored-by: zeripath <[email protected]>
M4RKUS-11111 · Oct 27, 2020 · aa52f44 · aa52f44
1 parent 28133a8
commit aa52f44
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/routers/api/v1/repo/pull.go b/routers/api/v1/repo/pull.go
@@ -284,6 +284,12 @@ func CreatePullRequest(ctx *context.APIContext, form api.CreatePullRequestOption
 	//   "422":
 	//     "$ref": "#/responses/validationError"
 
+	if form.Head == form.Base {
+		ctx.Error(http.StatusUnprocessableEntity, "BaseHeadSame",
+			"Invalid PullRequest: There are no changes between the head and the base")
+		return
+	}
+
 	var (
 		repo        = ctx.Repo.Repository
 		labelIDs    []int64