Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Optimizer 4 #64

Merged
merged 28 commits into from
Nov 13, 2023
Merged

Improve Optimizer 4 #64

merged 28 commits into from
Nov 13, 2023

Conversation

memelotsqui
Copy link
Collaborator

This PR cinludes:

  • Support to keep standard material and mtoon material or merge them together
  • Support separate materials when they have transparency
  • Standard material will now include smoothness and metalness map
  • Removed download button when user has not uploaded any model in omptimizer
  • Pick atlas size for different atlases
  • Save user selected options to local storage

image

@memelotsqui
set ui for different material size
cc2a3cc
@memelotsqui
add select export material option
9b40ace
@memelotsqui
update css for optimizer
b8543f4
@memelotsqui
set text to right side in model information
b07e8e5
@memelotsqui
move clone mesh outside create texture-atlas
00d7e0f
@memelotsqui
utils function to get sorted materials
ce1b195
@memelotsqui
update modelinformation component to use new function to sort materials
953863f
@memelotsqui
update name to be mToonAtlasSize
390612a
@memelotsqui
correctly detect std material or vrm material
1eaf356
@memelotsqui
texture atlas per material type
829dccb
@memelotsqui
modularize code and update texture atlas calls
38e3fde
@memelotsqui
functions to separate materials
01f4863
@memelotsqui
remove logs
409e59c
@memelotsqui
update downloadvrm call to code refactor
4b45dba
@memelotsqui
code refactor: save variables into object options
3501783
@memelotsqui
update functions to work with code refactor
71c5643
@memelotsqui
update optimizer to reflect code refactor
4676aee
@memelotsqui
send atlas size in options parameter
f3a15a4
@memelotsqui
add comment description to downloadVRM call
458730b
@memelotsqui
src/library/VRMExporterv0.js
76523c6
@memelotsqui
save vrm material to material userdata
90dc903
@memelotsqui
add support for metallic roughness texture
cd5ce05
@memelotsqui
update texture atlas generation to include metallic roughness
1e4df6c
@memelotsqui
remove logs
550a3ff
@memelotsqui
filter null images
ae1c5ee
@memelotsqui
remove normal map from atlas for now
4fc93b7
@memelotsqui
remove download button when no vrm is uploadded
3cc624c
@memelotsqui
save selection to local storage
80316e8
@memelotsqui memelotsqui changed the title Optimizer improve 4 Improve Optimizer 4 Nov 13, 2023
@madjin madjin merged commit d008d82 into main Nov 13, 2023
0 of 2 checks passed
@memelotsqui memelotsqui mentioned this pull request Nov 14, 2023
Closed
@memelotsqui memelotsqui deleted the optimizer-improve-4 branch December 30, 2023 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@memelotsqui @madjin