Add script to merge results of mteb-fr with those of mteb-original #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
MathieuCiancone
approved these changes
Feb 26, 2024
| @@ -34,7 +34,8 @@ def model_name(self): | |||
| return self._model_name | |||
|
|
|||
| def encode_documents(self, input: Documents) -> Embeddings: | |||
| return self.model(input).numpy().tolist() | |||
| truncated_documents = [" ".join(x.split(' ')[:self.max_token_length]) for x in input] | |||
There was a problem hiding this comment.
Why splitting on words instead of tokens ?
AbstractEmbeddingFunctionalready has a truncation method implemented, which is called before theencode_documentsmethod so no need to implement truncation here :)
There was a problem hiding this comment.
I think @wissam-sib added this because we couldn't run MUSE-large. But it was on another PR and it was already merged into main I think (I rebased this branch). Should I remove this ?
| 'devtest' | ||
| ] | ||
|
|
||
| def split_model_name(model_name: str): |
There was a problem hiding this comment.
more elegant to use os.path.basename(mypath) to get the last folder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mteb/resultsrepo (bash script to installgit lfsand clonemteb/resultsrepository from HF)