Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating datasets and models correlation figures #137

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Updating datasets and models correlation figures #137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f08df05
Updating datasets and models correlation figures
wissam-sib Jun 12, 2024
325922a
cleaning figures
wissam-sib Jun 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified analyses_outputs/results_correlations/spearman_corr_heatmap_datasets.pdf
View file
Open in desktop
Binary file not shown.
Binary file modified analyses_outputs/results_correlations/spearman_corr_heatmap_datasets.png
View file
Open in desktop
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je crois qu'on devrait virer les noms des splits : AmazonReviewClassification_test -> AmazonReviewClassification.

Par défaut on garde le test, sinon on prend dev et on le mentionne dans la caption de la figure

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ai mis a jour, good point ! J'ai aussi sort by task

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified analyses_outputs/results_correlations/spearman_corr_heatmap_models.pdf
View file
Open in desktop
Binary file not shown.
Binary file modified analyses_outputs/results_correlations/spearman_corr_heatmap_models.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
56 changes: 29 additions & 27 deletions analyses_outputs/results_correlations/spearman_corr_matrix_datasets.csv
View file
Open in desktop

Large diffs are not rendered by default.

99 changes: 52 additions & 47 deletions analyses_outputs/results_correlations/spearman_corr_matrix_models.csv
View file
Open in desktop

Large diffs are not rendered by default.

9 changes: 9 additions & 0 deletions script_mteb_french/results_analysis/dataset_correlation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,19 @@ def parse_args() -> Namespace:
# Get results
rp = ResultsParser()
results_df = rp(args.results_folder, return_main_scores=False)
# sort by first level before dropping it
results_df = results_df.sort_index(axis=1)
results_df = results_df.droplevel(0, axis=1)
results_df.columns = results_df.columns.map(
lambda x: x.split("_")[0]
)
#remove duplicates columns and keep the first one
results_df = results_df.loc[:,~results_df.columns.duplicated()]
results_df.index = results_df.index.map(
lambda x: os.path.basename(x)
)
# keep first index if duplicated
results_df = results_df[~results_df.index.duplicated(keep="first")]
# Prepare output folder
if not os.path.exists(args.output_folder):
os.makedirs(args.output_folder)
Expand Down