Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update figures - THIS WILL BE CLOSED DO NOT USE #123

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

imenelydiaker
Copy link

@imenelydiaker imenelydiaker commented Jun 1, 2024

Related to #117

MODELS_TO_IGNORE = ['voyage-01', 'voyage-02', 'voyage-lite-01']
MODELS_TO_IGNORE = ['voyage-01', 'voyage-02', 'voyage-lite-01', 'Geotrend/distilbert-base-en-fr-es-pt-it-cased',
'Geotrend/bert-base-10lang-cased', 'Geotrend/bert-base-15lang-cased', 'Geotrend/bert-base-25lang-cased',
'dangvantuan/sentence-camembert-large', 'distilbert-base-uncased']
Copy link

@wissam-sib wissam-sib Jun 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why ignoring sentence-camembert-large? It was one of the best models

Copy link
Author

@imenelydiaker imenelydiaker Jun 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because there is a newer version: Lajavaness/sentence-camembert-large, see description in this link. They say it's better than the other one.

I see that Lajavaness proposes a sentence-flaubert, maybe we should add it instead of flaubert

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just saw that! Nice

@imenelydiaker imenelydiaker marked this pull request as draft June 5, 2024 08:58
@imenelydiaker imenelydiaker changed the title Update figures Update figures - THIS WILL BE CLOSED Jun 11, 2024
@imenelydiaker imenelydiaker changed the title Update figures - THIS WILL BE CLOSED Update figures - THIS WILL BE CLOSED DO NOT USE Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants