Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

12 featfew updates #13

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

12 featfew updates #13

wants to merge 2 commits into from

Conversation

MathieuCiancone
Copy link
Contributor

closes #12

@MathieuCiancone MathieuCiancone self-assigned this Dec 12, 2024
@MathieuCiancone MathieuCiancone linked an issue Dec 12, 2024 that may be closed by this pull request
feat:few-updates #12
Open
9 tasks
imenelydiaker
imenelydiaker approved these changes Dec 19, 2024
View reviewed changes
chromacache/embedding_functions/azure_embedding_function.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe rename the fiel to respect the naming convention? or rename other functions (it'd be great to just have a standard for all modules names)

chromacache/embedding_functions/ovh_embedding_function.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as previously on the file name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imenelydiaker imenelydiaker imenelydiaker approved these changes

Assignees

@MathieuCiancone MathieuCiancone

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat:few-updates
2 participants
@MathieuCiancone @imenelydiaker