This repository has been archived by the owner on Dec 25, 2023. It is now read-only.
Automatically focus first interacive element #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the regression noticed by @kamil4 on Gitter at Oct 15th 2022 07:17.
The first interactive element was not automatically focused after opening a dialog. There were two independent issues involved:
selectfor input elements and text areas which selects all existing text, but does not give focus. We must callfocus, too. This regression has been introduced by the change from jQuery in favor of native DOM operations. The oldselectof jQuery always implies an implicitfocus.