Php 32bit - Zip-stream with version 2.1 instead of 3.1

[ildyria]

Fixes #2933

We leverage 2 traits one for each implementation of ZipStream.
The code is moved to a BaseArchive class and the installation decides which class to use.

[ildyria]

@RustyPotato could you try this branch ?

[codecov]

Codecov Report

Attention: Patch coverage is 43.85965% with 32 lines in your changes missing coverage. Please review.

Project coverage is 90.57%. Comparing base (2834e86) to head (f722a2d).

Additional details and impacted files

[ildyria]

@RustyPotato you may need to remove the composer.lock before doing your install, but in theory it should now support your 32 bit install.

[tinohager]

Couldn't the zip creation also be outsourced to the client?
https://github.com/gildas-lormeau/zip.js

the latest 2 version would be 2.4.0
https://github.com/maennchen/ZipStream-PHP/releases/tag/2.4.0

[ildyria]

Couldn't the zip creation also be outsourced to the client? gildas-lormeau/zip.js

The problem is that the response is in streaming mode, In version 3 of Lychee, we were creating the zip file serverside before sending it. This has changed by the use of ZipStream, but I am not knowledgeable enough of how streaming files works with http, not how it would be possible for the client to know, that is one file, that is the next file.
The advantage of streaming the zip file directly is that the client no longer need to keep the page open and can just have it run in a background tab.

[ildyria]

@RustyPotato please confirm otherwise I won't be able to merge this. :)

[RustyPotato]

My apologies for the long delay, this took longer than expected to get back to. I have gotten it to work, and it's running successfully. (Link). Now just for me to set all the configs properly.

As we were messing with the zip library, had to double check what that'd look like. It gives off an empty zip file. So if I want that fixed, I'll probably need to do so myself eventually, but it's not an essential feature for me.

Having said that, it seems the demo site is also having difficulties with it too. (Link)

[ildyria]

As we were messing with the zip library, had to double check what that'd look like. It gives off an empty zip file. So if I want that fixed, I'll probably need to do so myself eventually, but it's not an essential feature for me.

I checked on 64bit install it is working as expected. I will try to see with the 32bit version...

I can confirm the empty zip behaviour on the 32 bit.

[ildyria]

@RustyPotato this should fix the empty zip issue you were observing.