Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop laminas-text, add related source files to Lychee #2876

Merged
merged 3 commits into from
Jan 4, 2025
Merged

Drop laminas-text, add related source files to Lychee #2876

merged 3 commits into from
Jan 4, 2025

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Jan 4, 2025 •
edited
Loading

Laminas is abandonned.
I check we only depend on two files, imported those in lychee.

  • phpstan fix
  • codecov bump number of build required to 9 instead of 6 to avoid the error + mail...

@ildyria ildyria added this to the 6.3 milestone Jan 4, 2025
@ildyria ildyria added the Review: easy Easy review expected: probably just need a quick to go through. label Jan 4, 2025
@ildyria ildyria requested a review from d7415 January 4, 2025 11:16
@codecov Codecov
Copy link

codecov bot commented Jan 4, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 76.31579% with 9 lines in your changes missing coverage. Please review.

Project coverage is 84.05%. Comparing base (3693ede) to head (6b1d830).
Report is 1 commits behind head on master.

Additional details and impacted files

@ildyria ildyria merged commit dde9b5a into master Jan 4, 2025
52 checks passed
@ildyria ildyria deleted the laminas-retired branch January 4, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d7415 d7415 d7415 approved these changes

Assignees
No one assigned
Labels
Review: easy Easy review expected: probably just need a quick to go through.
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.
2 participants
@ildyria @d7415