Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not show placeholder data in statistics #2676

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Do not show placeholder data in statistics #2676

merged 1 commit into from
Nov 13, 2024

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Nov 12, 2024 •
edited
Loading

On my server:

Original                     288.98 GB
Medium HiDPI                 831.10 MB
Medium                        12.21 GB
Thumb HiDPI                  105.44 MB
Thumb                          2.14 GB
Square thumb HiDPI             2.48 GB
Square thumb                 945.86 MB
Low Quality Image Placeholder 12.63 MB

They are proportionally insignificant and are stored base64 encoded in DB...

@ildyria ildyria requested a review from d7415 November 12, 2024 14:37
@ildyria ildyria added the Review: easy Easy review expected: probably just need a quick to go through. label Nov 12, 2024
@ildyria ildyria added this to the 6.1.0 milestone Nov 12, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 12, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.

Project coverage is 84.82%. Comparing base (bbdd883) to head (6299df5).
Report is 5 commits behind head on master.

Additional details and impacted files

@ildyria ildyria merged commit 0629657 into master Nov 13, 2024
49 checks passed
@ildyria ildyria deleted the no-placeholder-stats branch November 13, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d7415 d7415 d7415 approved these changes

Assignees
No one assigned
Labels
Review: easy Easy review expected: probably just need a quick to go through.
Projects
None yet
Milestone
6.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ildyria @d7415