Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix login menu not visible when set to the right. #2605

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Oct 27, 2024

Fixes #2604

@ildyria ildyria added this to the 6.0.1 milestone Oct 27, 2024
@@ -271,7 +270,7 @@ const menu = computed(() =>
icon: "pi pi-sign-in",
type: "fn",
callback: lycheeStore.toggleLogin,
if: props.user.id === null && !isLoginLeft,
if: props.user.id === null && !isLoginLeft.value,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the reason why it was not showing...

Copy link

codecov bot commented Oct 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.73%. Comparing base (d25cd64) to head (d703c7f).
Report is 2 commits behind head on master.

Additional details and impacted files

@ildyria ildyria added the Review: easy Easy review expected: probably just need a quick to go through. label Oct 27, 2024
@ildyria ildyria merged commit 7251eac into master Oct 28, 2024
46 checks passed
@ildyria ildyria deleted the fix-login-on-right branch October 28, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review: easy Easy review expected: probably just need a quick to go through.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants