Fixes HTTP 500 "Attempt to read property "photo_id" on null" on album page when no photo is found for header #2396
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that
\App\Livewire\Components\Pages\Gallery\Album::fetchHeaderUrl()
does not properly handle the situation when no photo of the right ratio/type combination can be found in the content of the album.And in this case, the result is pretty ugly 😕
The quick and dirty solution here is just to return
null
, at least until a better way to handle the case is found.