Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve diagnostics by adding check of temporary file systems #2251

Merged
merged 1 commit into from
Jan 29, 2024
Merged

Improve diagnostics by adding check of temporary file systems #2251

merged 1 commit into from
Jan 29, 2024

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Jan 27, 2024

No description provided.

@ildyria ildyria added the Review: easy Easy review expected: probably just need a quick to go through. label Jan 27, 2024
@ildyria ildyria added this to the 5.2.0 milestone Jan 27, 2024
@ildyria ildyria requested a review from a team January 27, 2024 18:22
@ildyria ildyria mentioned this pull request Jan 27, 2024
Closed
8 tasks
@codecov Codecov
Copy link

codecov bot commented Jan 27, 2024 •
edited
Loading

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (f71f756) 86.09% compared to head (7e0234e) 85.98%.

Additional details and impacted files

@ildyria ildyria added the High Priority High priority issues label Jan 27, 2024
This was referenced Jan 27, 2024
Closed
Closed
@ildyria ildyria self-assigned this Jan 28, 2024
kamil4
kamil4 approved these changes Jan 28, 2024
View reviewed changes
Copy link
Contributor

@kamil4 kamil4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (not tested).

app/Actions/Diagnostics/Pipes/Checks/BasicPermissionCheck.php Show resolved Hide resolved
@ildyria ildyria changed the title Improve diagnostics by adding check of temporary file systems (used by upload) Improve diagnostics by adding check of temporary file systems Jan 29, 2024
@ildyria ildyria merged commit 327f899 into master Jan 29, 2024
33 checks passed
@ildyria ildyria deleted the improve-diagnostics branch January 29, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamil4 kamil4 kamil4 approved these changes

Assignees

@ildyria ildyria

Labels
High Priority High priority issues Review: easy Easy review expected: probably just need a quick to go through.
Projects
None yet
Milestone
5.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ildyria @kamil4