Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No more album ID within the history #2242

Merged
merged 4 commits into from
Jan 25, 2024
Merged

No more album ID within the history #2242

merged 4 commits into from
Jan 25, 2024

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Jan 23, 2024

Redundant info which could simply be hard coded...

@ildyria ildyria added the Review: easy Easy review expected: probably just need a quick to go through. label Jan 23, 2024
@ildyria ildyria added this to the 5.2.0 milestone Jan 23, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 23, 2024 •
edited
Loading

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (1e3b000) 86.28% compared to head (db4c35e) 86.02%.
Report is 2 commits behind head on master.

Additional details and impacted files

kamil4
kamil4 approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@kamil4 kamil4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (in some free time I will need to learn what this whole job history table is about, as I don't remember it 😉).

@ildyria ildyria merged commit 7ce7efd into master Jan 25, 2024
33 checks passed
@ildyria ildyria deleted the remove-albumId-from-JobHistory branch January 25, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamil4 kamil4 kamil4 approved these changes

Assignees
No one assigned
Labels
Review: easy Easy review expected: probably just need a quick to go through.
Projects
None yet
Milestone
5.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ildyria @kamil4