Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve token guard to not crash when provided with Basic Auth #2193

Merged
merged 1 commit into from
Jan 14, 2024
Merged

Improve token guard to not crash when provided with Basic Auth #2193

merged 1 commit into from
Jan 14, 2024

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Jan 13, 2024

Fixes #2042

@codecov Codecov
Copy link

codecov bot commented Jan 13, 2024 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (b8ace78) 86.35% compared to head (11667f4) 86.00%.

Additional details and impacted files

@ildyria ildyria requested a review from a team January 13, 2024 15:38
@ildyria ildyria self-assigned this Jan 13, 2024
@ildyria ildyria added the Review: easy Easy review expected: probably just need a quick to go through. label Jan 13, 2024
@ildyria ildyria added this to the 5.0.4 milestone Jan 13, 2024
@ildyria ildyria marked this pull request as ready for review January 13, 2024 15:38
@ildyria ildyria merged commit e1faf33 into master Jan 14, 2024
33 checks passed
@ildyria ildyria deleted the fix-2042 branch January 14, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qwerty287 qwerty287 qwerty287 approved these changes

Assignees

@ildyria ildyria

Labels
Review: easy Easy review expected: probably just need a quick to go through.
Projects
None yet
Milestone
5.0.4
Development

Successfully merging this pull request may close these issues.

400 bad request response if protected by http basic auth
2 participants
@ildyria @qwerty287