Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support very old versions (untestable code) #1826

Merged
merged 2 commits into from
May 7, 2023
Merged

Support very old versions (untestable code) #1826

merged 2 commits into from
May 7, 2023

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented May 7, 2023 •
edited
Loading

Fixes #1779

Tested with version 4.4.0:

  • Created a new Lychee instance at version 4.4.0
  • composer install with ignore req and fix vendor autoload.
  • Created an admin user
  • Uploaded an album & photo
  • switched to version 4.8.0
  • apply migration from webinterface (migration requires to be on master branch but at least it no longer pop a 403).
  • some trickery to make Lychee believe we are on master and migration passes.
  • It generates a byte allocation error but the migration worked successfully.

Unfortunately I could not test on version 4.0.8 as this required an older php version.

@ildyria ildyria requested a review from qwerty287 May 7, 2023 11:44
@ildyria ildyria self-assigned this May 7, 2023
@ildyria ildyria added Review: easy Easy review expected: probably just need a quick to go through. High Priority High priority issues labels May 7, 2023
@codecov
Copy link

codecov bot commented May 7, 2023 •
edited
Loading

Codecov Report

Merging #1826 (a4b9f99) into master (4a28690) will decrease coverage by 0.40%.
The diff coverage is 27.77%.

Additional details and impacted files

@ildyria ildyria merged commit a132445 into master May 7, 2023
@ildyria ildyria deleted the fix-1779 branch May 7, 2023 12:31
@ildyria ildyria added this to the 4.8.1 milestone May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qwerty287 qwerty287 qwerty287 approved these changes

Assignees

@ildyria ildyria

Labels
High Priority High priority issues Review: easy Easy review expected: probably just need a quick to go through.
Projects
None yet
Milestone
4.8.1
Development

Successfully merging this pull request may close these issues.

Updating 4.4.0 to 4.7.0 fails with 403: incorrect username or password
2 participants
@ildyria @qwerty287