Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add backend implementation to use file's last modified time #1821

Merged
merged 12 commits into from
May 7, 2023
Merged

Add backend implementation to use file's last modified time #1821

merged 12 commits into from
May 7, 2023

Conversation

wladif
Copy link
Contributor

@wladif wladif commented May 4, 2023 •
edited
Loading

This PR adds the remaining back-end logic for using the file's last modified time when there's no Exif creation time thus closing #1729.

wladif added 4 commits May 4, 2023 19:36
Add taken_at_fallback setting
ea28746 
save1

save 2

save 3

save 4

save 6

fix test

Fix extraction from videos

Made request param optional

Revert "Made request param optional"

This reverts commit 2af4969.

phpstan fixes

Save

Changed the name of the setting
Implementation done
a958603
Fix missing param
e4afeb1
Fix phpstan
e2c12d7
@wladif wladif changed the title Backend implementation of enhancement #1729 Backend implementation of the enhancement to use file's last modified time when Exif data is missing May 4, 2023
@wladif wladif changed the title Backend implementation of the enhancement to use file's last modified time when Exif data is missing Fix #1729 May 4, 2023
@wladif wladif changed the title Fix #1729 Add backend implementation to use file's last modified time May 4, 2023
@codecov
Copy link

codecov bot commented May 4, 2023 •
edited
Loading

Codecov Report

Merging #1821 (68ed410) into master (4a28690) will decrease coverage by 0.46%.
The diff coverage is 100.00%.

Additional details and impacted files

@wladif wladif deleted the branch LycheeOrg:master May 5, 2023 13:33
@wladif wladif closed this May 5, 2023
@wladif wladif deleted the master branch May 5, 2023 13:33
@wladif wladif restored the master branch May 5, 2023 13:36
@wladif wladif reopened this May 5, 2023
@wladif wladif marked this pull request as ready for review May 6, 2023 12:55
@ildyria ildyria mentioned this pull request May 6, 2023
Merged
ildyria
ildyria approved these changes May 7, 2023
View reviewed changes
Copy link
Member

@ildyria ildyria left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Did some very very minor changes to align with the repo (e.g. test constants ordered alphabetically).

@ildyria ildyria merged commit 727a857 into LycheeOrg:master May 7, 2023
@ildyria ildyria added this to the 4.8.1 milestone May 7, 2023
@wladif wladif mentioned this pull request May 8, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ildyria ildyria ildyria approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.8.1
Development

Successfully merging this pull request may close these issues.
2 participants
@wladif @ildyria