Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jobs processing #1785

Merged
merged 8 commits into from
Apr 7, 2023
Merged

Add jobs processing #1785

merged 8 commits into from
Apr 7, 2023

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Apr 6, 2023

Instead of processing live, we now support the use of Jobs & Queues.
This ensure faster response when jobs are enabled.

This pull request adds a new config use_job_queues with default to 0.
By setting it to 1, import will be added to a processing queue.

Such jobs on the queue can then be executed by running php artisan queue:work on server side.

@ildyria ildyria marked this pull request as draft April 6, 2023 00:27
@ildyria ildyria marked this pull request as ready for review April 6, 2023 16:43
@ildyria ildyria requested a review from qwerty287 April 6, 2023 16:43
@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Merging #1785 (569f487) into master (a46aa7f) will decrease coverage by 0.29%.
The diff coverage is 83.11%.

Additional details and impacted files

Copy link
Contributor

@qwerty287 qwerty287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, untested

@qwerty287
Copy link
Contributor

Maybe we can add some tests for this

@ildyria
Copy link
Member Author

ildyria commented Apr 7, 2023

Maybe we can add some tests for this

Done.

I actually noticed that we can just switch everything to jobs if we are using the sync for queue connection. The problem is that the code is no longer dependent if it is a duplicate or not. :/

@ildyria ildyria self-assigned this Apr 7, 2023
@ildyria ildyria requested a review from qwerty287 April 7, 2023 11:15
@ildyria ildyria merged commit c27a1dc into master Apr 7, 2023
@ildyria ildyria deleted the jobs-processing branch April 7, 2023 12:21
d7415 added a commit to LycheeOrg/Lychee-Docker that referenced this pull request Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants