Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

composer update #1773

Merged
merged 2 commits into from
Mar 8, 2023
Merged

composer update #1773

merged 2 commits into from
Mar 8, 2023

Conversation

qwerty287
Copy link
Contributor

No description provided.

@qwerty287 qwerty287 added the dependencies Pull requests that update a dependency file label Mar 8, 2023
@qwerty287 qwerty287 added this to the 4.7.2 milestone Mar 8, 2023
@qwerty287 qwerty287 requested a review from a team March 8, 2023 10:39
@ildyria
Copy link
Member

ildyria commented Mar 8, 2023 •
edited
Loading

For phpstan, add

/** @var NsCollection<Album> $albums */
/** @var ?NsCollection<Album> $sharedAlbums */

before line

list($albums, $sharedAlbums) = $albums->partition(fn (Album $album) => $album->owner_id === $userID);

The type inference by partition is not correct.

ildyria
ildyria approved these changes Mar 8, 2023
View reviewed changes
Copy link
Member

@ildyria ildyria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the phpstan problem is fixed.

@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Merging #1773 (5de61e2) into master (1528e86) will decrease coverage by 0.51%.
The diff coverage is n/a.

Additional details and impacted files

@qwerty287 qwerty287 merged commit fb4e919 into master Mar 8, 2023
@qwerty287 qwerty287 deleted the update-composer branch March 8, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ildyria ildyria ildyria approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
4.7.2
Development

Successfully merging this pull request may close these issues.
2 participants
@qwerty287 @ildyria