-
-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add setting auto_fix_orientation
to enable auto image rotation
#1766
Conversation
Currently, imported images are automatically rotated even when the editor_enabled is disabled, the automatic rotation takes place as part of the image normalization process. This feels a bit unintuitive and this PR fixes it by taking into account this setting when normalizing the image.
No, that setting is to allow the manual rotations buttons in the header. A better approach would be to create an You can use |
I've avoided adding another setting because to me it made more sense that if I, as a user, can't edit the image the system should not be allowed to do it either, this will not be the case with an extra setting (not without extra logic anyway). |
@wladif I fixed the formatting issue ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@ildyria Thanks for fixing the formatting. Yes, it's ready for review. |
auto_fix_orientation
to enable auto image rotation
Currently, imported images are automatically rotated even when the editor_enabled is disabled, the automatic rotation takes place as part of the image normalization process.
This feels a bit unintuitive and this PR fixes it by taking into account this setting when normalizing the image.