Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes locale not working (#1754) #1756

Merged
merged 2 commits into from
Feb 9, 2023
Merged

Fixes locale not working (#1754) #1756

merged 2 commits into from
Feb 9, 2023

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Feb 9, 2023

Fixes #1754

When moving to Resources, this was done at the same time as migrating the locale to lang/, this induced a small bug.
Should now be resolved.

@ildyria ildyria requested a review from a team February 9, 2023 14:19
@ildyria ildyria added Review: easy Easy review expected: probably just need a quick to go through. High Priority High priority issues labels Feb 9, 2023
@ildyria ildyria added this to the 4.7.2 milestone Feb 9, 2023
@codecov
Copy link

codecov bot commented Feb 9, 2023 •
edited
Loading

Codecov Report

Merging #1756 (7efe12d) into master (5533538) will decrease coverage by 0.37%.
The diff coverage is 100.00%.

Additional details and impacted files

@ildyria ildyria requested a review from qwerty287 February 9, 2023 17:02
@ildyria ildyria merged commit b2042e6 into master Feb 9, 2023
@ildyria ildyria deleted the fix-locale branch February 9, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qwerty287 qwerty287 qwerty287 approved these changes

Assignees
No one assigned
Labels
High Priority High priority issues Review: easy Easy review expected: probably just need a quick to go through.
Projects
None yet
Milestone
4.7.2
Development

Successfully merging this pull request may close these issues.

Language support stopped working
2 participants
@ildyria @qwerty287