Smart album - On This Day - new feature #1607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ildyria
reviewed
Nov 27, 2022
Co-authored-by: Benoît Viguier <[email protected]>
|
@aldjordje I sent you an Triage invite so you are able to run the pipelines without waiting for our approval. :) |
ildyria
reviewed
Nov 27, 2022
Co-authored-by: Benoît Viguier <[email protected]>
qwerty287
reviewed
Nov 27, 2022
Co-authored-by: qwerty287 <[email protected]>
qwerty287
reviewed
Nov 27, 2022
|
@aldjordje is this ready for review ? :) |
|
@ildyria Thank you for enabling exceptions for 500 errors to be displayed. Without it, I couldn't figure out what the problem was :) |
ildyria
requested changes
Dec 6, 2022
There was a problem hiding this comment.
99% LGTM.
Please add the following standalone test to AlbumTest.php.
- Get today date
- Log as admin
- Upload photo -> get the photo ID
- Get photo model and set taken_at of the picture to today - 1 year.
- Open "On this day"
- Check that photo ID is present in the response.
- Log out.
This will guarantee that the SQL request is also working. :)
Some pictures do not have a taken_at (exif data missing), maybe in those case we could consider the created_at instead ? See https://github.com/aldjordje/Lychee/pull/1/files :)
Improve query to support created_at when taken_at is null
|
@ildyria I was thinking about the test and I couldn't think of a way to write it. I'll add it today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The smart album "On This Day" will allow users to see all the photos taken on this day.
Closes #1599