Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

more coverage #1605

Merged
merged 1 commit into from
Nov 28, 2022
Merged

more coverage #1605

merged 1 commit into from
Nov 28, 2022

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Nov 27, 2022

No description provided.

@ildyria ildyria requested a review from a team November 27, 2022 13:46
@ildyria ildyria added this to the 4.6.3 milestone Nov 27, 2022
@codecov
Copy link

codecov bot commented Nov 27, 2022

Codecov Report

Merging #1605 (3a6146d) into master (1aa57e0) will decrease coverage by 0.42%.
The diff coverage is n/a.

Additional details and impacted files

qwerty287
qwerty287 approved these changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@qwerty287 qwerty287 left a comment •
edited by ildyria
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this is the best idea to increase code coverage, but I'm fine with it :)

@ildyria
Copy link
Member Author

ildyria commented Nov 28, 2022

Those are extreme edge cases where we need to throw exceptions or modify significantly the server on which Lychee run.
That's why I did it as such. :(

@ildyria ildyria merged commit 7b8eaed into master Nov 28, 2022
@ildyria ildyria deleted the coverage-pipes branch November 28, 2022 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qwerty287 qwerty287 qwerty287 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.6.3
Development

Successfully merging this pull request may close these issues.
2 participants
@ildyria @qwerty287