Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an option to regenerate square thumbs #1545

Merged
merged 2 commits into from
Oct 4, 2022
Merged

Add an option to regenerate square thumbs #1545

merged 2 commits into from
Oct 4, 2022

Conversation

kamil4
Copy link
Contributor

@kamil4 kamil4 commented Oct 3, 2022

Fixes #1507

d7415
d7415 approved these changes Oct 3, 2022
View reviewed changes
Copy link
Contributor

@d7415 d7415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (not tested)

@d7415
Copy link
Contributor

d7415 commented Oct 3, 2022 •
edited
Loading

Wait, scrap that, test missing..

Edit to add: Our test output is awful.

@d7415
Copy link
Contributor

d7415 commented Oct 3, 2022

Test fixed (sorry if I stepped on you)

@kamil4 kamil4 mentioned this pull request Oct 3, 2022
Closed
@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Merging #1545 (789317b) into master (c4b6d50) will decrease coverage by 0.73%.
The diff coverage is n/a.

Additional details and impacted files

@ildyria ildyria merged commit a02111d into master Oct 4, 2022
@ildyria ildyria deleted the add-thumbs branch October 4, 2022 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d7415 d7415 d7415 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Black photos in album (manual error, how to fix?)
3 participants
@kamil4 @d7415 @ildyria