Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Laravel 9 + switch to Laragear/WebAuthn #1469

Merged
merged 34 commits into from
Oct 21, 2022
Merged

Upgrade to Laravel 9 + switch to Laragear/WebAuthn #1469

merged 34 commits into from
Oct 21, 2022

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Aug 19, 2022

No description provided.

@ildyria ildyria mentioned this pull request Aug 20, 2022
Merged
@nagmat84
Copy link
Collaborator

Please keep also in mind that the stream handling with respect to the change from Flysystem v1 to v3 needs changes.

@ildyria
Copy link
Member Author

ildyria commented Aug 20, 2022 •
edited
Loading

Please keep also in mind that the stream handling with respect to the change from Flysystem v1 to v3 needs changes.

No worries, I have not forgotten. Do you mind if I let you fix that part while I focus on the WebAuthn problem? :)
I can also give a shot to the streams, but I have never worked with them before. But I can try. :)

@ildyria ildyria force-pushed the upgrade-laravel-9 branch 2 times, most recently from 058ddc7 to d461d47 Compare August 27, 2022 07:57
@ildyria ildyria modified the milestones: 4.7.0, 4.6.x Aug 27, 2022
@codecov
Copy link

codecov bot commented Sep 7, 2022 •
edited
Loading

Codecov Report

Merging #1469 (096500d) into master (80bbd41) will decrease coverage by 1.01%.
The diff coverage is 52.70%.

Additional details and impacted files

@ildyria
Copy link
Member Author

ildyria commented Sep 7, 2022

Finally !

@ildyria ildyria marked this pull request as ready for review September 7, 2022 18:34
@ildyria ildyria requested review from nagmat84 and a team September 7, 2022 18:34
@ildyria ildyria mentioned this pull request Sep 8, 2022
Merged
@nagmat84
Copy link
Collaborator

nagmat84 commented Sep 8, 2022

I guess I need at least the upcoming weekend to step through this PR. First, I would like to put my attention on #1368 and #1366 which are a) much smaller and b) longer in the pipeline.

@ildyria
Copy link
Member Author

ildyria commented Sep 8, 2022

I guess I need at least the upcoming weekend to step through this PR. First, I would like to put my attention on #1368 and #1366 which are a) much smaller and b) longer in the pipeline.

I would be happy if also #1480 would take priority over this one. :'D

@ildyria ildyria modified the milestones: 4.6.x, 4.6.2 Sep 28, 2022
nagmat84
nagmat84 reviewed Sep 29, 2022
View reviewed changes
app/Actions/Album/Delete.php Show resolved Hide resolved
app/Actions/Install/PermissionsChecker.php Show resolved Hide resolved
app/Actions/User/Notify.php Outdated Show resolved Hide resolved
app/Assets/SizeVariantGroupedWithRandomSuffixNamingStrategy.php Show resolved Hide resolved
app/Console/Commands/FixPermissions.php Outdated Show resolved Hide resolved
app/Factories/AlbumFactory.php Outdated Show resolved Hide resolved
app/Http/Controllers/Administration/SettingsController.php Show resolved Hide resolved
app/Http/Controllers/WebAuthn/WebAuthnLoginController.php Outdated Show resolved Hide resolved
app/Http/Controllers/WebAuthn/WebAuthnLoginController.php Outdated Show resolved Hide resolved
nagmat84
nagmat84 requested changes Sep 29, 2022
View reviewed changes
Copy link
Collaborator

@nagmat84 nagmat84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

98 of 116 files.

app/Http/Controllers/WebAuthn/WebAuthnLoginController.php Outdated Show resolved Hide resolved
app/Http/Controllers/WebAuthn/WebAuthnManageController.php Outdated Show resolved Hide resolved
app/Http/Controllers/WebAuthn/WebAuthnRegisterController.php Outdated Show resolved Hide resolved
app/Http/Controllers/WebAuthn/WebAuthnRegisterController.php Outdated Show resolved Hide resolved
app/Http/Middleware/LocalStorageOnly.php Outdated Show resolved Hide resolved
database/migrations/2021_12_04_181200_refactor_models.php Outdated Show resolved Hide resolved
database/migrations/2021_12_04_181200_refactor_models.php Outdated Show resolved Hide resolved
database/migrations/2022_07_09_130303_create_webauthn_credentials.php Outdated Show resolved Hide resolved
database/migrations/2022_07_09_130303_create_webauthn_credentials.php Outdated Show resolved Hide resolved
database/migrations/2022_07_09_130303_create_webauthn_credentials.php Outdated Show resolved Hide resolved
@qwerty287 qwerty287 mentioned this pull request Oct 20, 2022
Merged
nagmat84
nagmat84 reviewed Oct 20, 2022
View reviewed changes
app/Actions/User/Notify.php Outdated Show resolved Hide resolved
app/Actions/User/Notify.php Outdated Show resolved Hide resolved
app/Http/Controllers/Administration/SettingsController.php Show resolved Hide resolved
nagmat84
nagmat84 reviewed Oct 20, 2022
View reviewed changes
app/Image/FlysystemFile.php Outdated Show resolved Hide resolved
app/Image/StreamStatFilter.php Outdated Show resolved Hide resolved
database/migrations/2022_07_09_130303_create_webauthn_credentials.php Show resolved Hide resolved
qwerty287
qwerty287 approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@qwerty287 qwerty287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some comments about comments :)

app/Actions/Import/FromUrl.php Outdated Show resolved Hide resolved
app/Image/DownloadedFile.php Outdated Show resolved Hide resolved
app/Image/FlysystemFile.php Outdated Show resolved Hide resolved
@ildyria ildyria merged commit 3872691 into master Oct 21, 2022
@ildyria ildyria deleted the upgrade-laravel-9 branch October 21, 2022 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d7415 d7415 d7415 left review comments

@qwerty287 qwerty287 qwerty287 approved these changes

@nagmat84 nagmat84 nagmat84 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.6.2
Development

Successfully merging this pull request may close these issues.
4 participants
@ildyria @nagmat84 @d7415 @qwerty287