-
-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Exec.php #1153
Update Exec.php #1153
Conversation
Update to allow multiple paths to be specified during import from server, separated by comma.
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Seems like you managed to get a Pull Request going. If you have any feedback with regard to https://lycheeorg.github.io/docs/contributions.html#illustrated-example please do tell so we can improve. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please ensure that the client (CLI or web front-end) already passes a correct array of paths to be imported and not a single string separated by semicolons. There might be cases where the semicolon is part of a path and thus must not be used as separator.
I did a path on that with associated PR: LycheeOrg/Lychee-front#308 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Untested, but looks sane.
Co-authored-by: qwerty287 <[email protected]>
I have not tested it either. 😇 |
@ildyria Before hitting the "apply" button the next time, read the comment below the suggestion ;-) #1153 (comment) The first suggestion contained a spelling error. |
Need to merge Lychee-front (waiting for other PR before) and then we can merge this. |
Update to allow multiple paths to be specified during import from server, separated by comma.