-
-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Php 32bit - Zip-stream with version 2.1 instead of 3.1 #2934
base: master
Are you sure you want to change the base?
Conversation
9e5b08a
to
98dd8f9
Compare
@RustyPotato could you try this branch ? |
@RustyPotato you may need to remove the composer.lock before doing your install, but in theory it should now support your 32 bit install. |
Couldn't the zip creation also be outsourced to the client? the latest 2 version would be 2.4.0 |
The problem is that the response is in streaming mode, In version 3 of Lychee, we were creating the zip file serverside before sending it. This has changed by the use of ZipStream, but I am not knowledgeable enough of how streaming files works with http, not how it would be possible for the client to know, that is one file, that is the next file. |
@RustyPotato please confirm otherwise I won't be able to merge this. :) |
Fixes #2933