Skip to content
This repository has been archived by the owner on Dec 25, 2023. It is now read-only.

Use stackblur from NPM instead of local file #337

Merged
merged 1 commit into from
Oct 20, 2022
Merged

Use stackblur from NPM instead of local file #337

merged 1 commit into from
Oct 20, 2022

Conversation

qwerty287
Copy link
Contributor

@qwerty287 qwerty287 requested a review from a team October 20, 2022 12:25
nagmat84
nagmat84 approved these changes Oct 20, 2022
View reviewed changes
Copy link
Collaborator

@nagmat84 nagmat84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes total sense to me.

I haven't tested it myself, hence my usual question: Did you run it and check whether the frame mode still works as expected, i.e. the margin contains a blurred version of the picture at the center?

@qwerty287
Copy link
Contributor Author

Yes, it's working.

@qwerty287 qwerty287 merged commit a89efe2 into master Oct 20, 2022
@qwerty287 qwerty287 deleted the stackblur-npm branch October 20, 2022 12:35
@qwerty287 qwerty287 mentioned this pull request Oct 21, 2022
Merged
@nagmat84 nagmat84 mentioned this pull request Nov 5, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nagmat84 nagmat84 nagmat84 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qwerty287 @nagmat84