Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Lux.transform in favor of Flux2Lux.jl #170

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Deprecate Lux.transform in favor of Flux2Lux.jl #170

merged 1 commit into from
Oct 19, 2022

Conversation

avik-pal
Copy link
Member

@avik-pal avik-pal commented Oct 2, 2022

TODOs:

  • Tests
  • Add to documentation

After this PR is merged:

  1. Deprecate Lux.transform
  2. Update Boltz.jl to use Flux2Lux
    • Add support for more Metalhead Models

@codecov
Copy link

codecov bot commented Oct 2, 2022

Codecov Report

Base: 88.09% // Head: 88.09% // No change to project coverage 👍

Coverage data is based on head (e6faa0c) compared to base (e6faa0c).
Patch has no changes to coverable lines.

❗ Current head e6faa0c differs from pull request most recent head 57890e5. Consider uploading reports for the commit 57890e5 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #170   +/-   ##
=======================================
  Coverage   88.09%   88.09%           
=======================================
  Files          19       19           
  Lines        1260     1260           
=======================================
  Hits         1110     1110           
  Misses        150      150           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@avik-pal avik-pal force-pushed the ap/f2l branch 6 times, most recently from 1364a18 to 04dfc4b Compare October 7, 2022 03:47
@avik-pal avik-pal changed the title [WIP] Deprecate Lux.transform in favor of Flux2Lux.jl Deprecate Lux.transform in favor of Flux2Lux.jl Oct 19, 2022
@avik-pal avik-pal merged commit c0eced3 into main Oct 19, 2022
@avik-pal avik-pal deleted the ap/f2l branch October 19, 2022 14:49
@avik-pal avik-pal restored the ap/f2l branch February 16, 2023 01:30
@avik-pal avik-pal deleted the ap/f2l branch February 17, 2023 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant