Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pass in RNG to shuffle #1188

Merged
merged 1 commit into from
Jan 8, 2025
Merged

fix: pass in RNG to shuffle #1188

merged 1 commit into from
Jan 8, 2025

Conversation

avik-pal
Copy link
Member

@avik-pal avik-pal commented Jan 7, 2025

fixes #1185

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 7, 2025 •
edited
Loading

Benchmark Results (ASV)

main 3639968... main/36399682d018a1...
basics/overhead 0.124 ± 0.0014 μs 0.124 ± 0.0014 μs 1.01
time_to_load 0.902 ± 0.0017 s 0.895 ± 0.01 s 1.01

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@avik-pal avik-pal force-pushed the ap/fix_sparse_init branch from 4125770 to b83d8b8 Compare January 7, 2025 23:34
@avik-pal avik-pal force-pushed the ap/fix_sparse_init branch from b83d8b8 to 3639968 Compare January 7, 2025 23:41
@avik-pal avik-pal merged commit 76dfdb5 into main Jan 8, 2025
39 of 50 checks passed
@avik-pal avik-pal deleted the ap/fix_sparse_init branch January 8, 2025 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sparse_init doesn't use provided rng fully
1 participant
@avik-pal