fix: init hidden state for reactant #1026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avik-pal
force-pushed
the
ap/rnn_reactant
branch
3 times, most recently
from
07f5336 to
33a4268
Compare
|
Once we tag a new Reactant release I can add tests and merge this |
avik-pal
force-pushed
the
ap/rnn_reactant
branch
2 times, most recently
from
aec71c6 to
c0e4564
Compare
Benchmark Results (ASV)
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
avik-pal
force-pushed
the
ap/rnn_reactant
branch
from
2f26994 to
f319646
Compare
|
only waiting for a new Reactant release. Then I will bump the minimum version requirements |
avik-pal
force-pushed
the
ap/rnn_reactant
branch
from
f4a15d7 to
7f3ba08
Compare
avik-pal
force-pushed
the
ap/rnn_reactant
branch
from
7f3ba08 to
7f32c98
Compare
avik-pal
force-pushed
the
ap/rnn_reactant
branch
from
7f32c98 to
40f305b
Compare
|
need to fix some of the scalar indexing issues now that scalar indexing is disabled in Reactant for non-CPU buffers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1025