versioning, picker component

[lazarusA]

No description provided.

[lazarusA]

Well, this is almost working, is EMPTY. What am I missing? @jkrumbiegel maybe is easy for you to spot the missing piece.

[jkrumbiegel]

@lazarusA the versions.js file is not present at the expected location, for Makie it is there https://docs.makie.org/versions.js

Edit:

Ah it's at https://luxdl.github.io/DocumenterVitepress.jl/versions.js so the prefix is missing and needs to be added

[asinghvi17]

@lazarusA I think you can use deploy_url from the MarkdownVitepress object to get the correct / expected URL, and then simply do a string replace on the component if necessary.

[lazarusA]

@asinghvi17 not here? I think I just need to add base here, isn't?

[asinghvi17]

Yes that should also work!

[jkrumbiegel]

doesn't base also contain dev or stable? If so that would not be correct

[lazarusA]

yeah, that doesn't work. It populates the menu, but the links are wrong.

[lazarusA]

Mmm, not sure how to propagate base to the Vue component. If I'm not too tired, I will check again later. It will be good to have this finally in the next release, which will be breaking either way. So, a big bump will also be needed. Someone that knows more about it, please commit the appropriate bump.

[lazarusA]

well, that last one worked. But, documenter is putting the wrong versions in the .js file.
https://luxdl.github.io/DocumenterVitepress.jl/versions.js

var DOC_VERSIONS = [
  "stable",
  "v0.1",
  "dev",
];

it looks like that, but it should be v0.1.1 a one is missing 😭 .

[tpoisot]

it looks like that, but it should be v0.1.1 a one is missing 😭 .

I think it's standard behavior, the major.minor version redirects to the latest patch version (that's how all my version.js files look)

Edit: yup - see https://github.com/JuliaDocs/Documenter.jl/blob/master/src/html/HTMLWriter.jl#L1476 - there's only one doc per minor release, so this seems to be working as intended 🎉

[jkrumbiegel]

What's weird is that the link https://luxdl.github.io/DocumenterVitepress.jl/v0.1/ looks like it 404s, but it actually correctly resolves to the symlinked v0.1.1. The javascript console shows an error saying "Hydration completed but contains mismatches". When I refresh the page I actually see the homepage for a split second before the 404 overrides it. So vitepress seems not to be able to deal with the different address for some reason?

[tpoisot]

This seems relevant? vuejs/vitepress#4160

[lazarusA]

I'm re-working also the logic, so that local builds also work without errors.

[lazarusA]

I tested this on DD, without any issues. Here, most likely something went wrong when creating the v0.1.1 folder version.

https://rafaqz.github.io/DimensionalData.jl/previews/PR804/

[jkrumbiegel]

@asinghvi17 by the way, the way these strings are replaced makes the code unnecessarily ugly. Couldn't you give every bit its own name like REPLACE_ME_DOCUMENTER_VITEPRESS_FAVICON? Then one could it splice in directly wherever needed without relying on the base: thing being present.

[asinghvi17]

We could, it's not super complicated to do either. Will look into it today.

[avik-pal]

In the Lux repo, only dev seems to show up https://lux.csail.mit.edu/dev/. Also there is a noticeable lag between the website being loaded and the time when the version picker appears. Any idea why that would be the case?

[lazarusA]

yes, is not taking the custom domain, and in turn getting the right path for versions.js. The lag is due to the waiting time, I did put 5s before going int the default, dev. Something might be wrong with my logic to load versions from custom domains.

Edit: The culprit https://github.com/LuxDL/Lux.jl/blob/e23b1a73257ea7094e89f13d64b1cbd609d09c8b/docs/src/.vitepress/config.mts#L59

it should be just '/versions.js', but the {getBaseRepository(baseTemp.base)} is given dev, since it thinks that the versions file is at https://lux.csail.mit.edu/dev/versions.js. This was not considered, I haven't invested time figuring this one yet. Thanks for testing.

[avik-pal]

it should be just '/versions.js'

This fixed it. Should we make a comment about that in the docs? Thanks for taking a look at this

[thofma]

Out of curiosity, what is the status of this? For my own project, shall I just copy it from https://lux.csail.mit.edu/dev/?