feat: add PositiveDefinite
#89
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avik-pal
force-pushed
the
positive-definite-container
branch
from
0445dd8 to
ebf0efe
Compare
avik-pal
reviewed
Jan 15, 2025
avik-pal
reviewed
Jan 23, 2025
avik-pal
reviewed
Jan 23, 2025
src/layers/containers.jl
Outdated
| end | ||
| function PositiveDefinite(model; in_dims::Integer, ψ=Base.Fix1(sum, abs2), | ||
| r=Base.Fix1(sum, abs2) ∘ -) | ||
| return PositiveDefinite(model, () -> zeros(in_dims), ψ, r) |
There was a problem hiding this comment.
pass in zeros32?
() -> copy(x0)
Here you can pass a dummy function that takes in (rng, in_dims) and ignores them
There was a problem hiding this comment.
Do you mean something like the change I just made?
avik-pal
reviewed
Jan 23, 2025
avik-pal
reviewed
Jan 23, 2025
avik-pal
reviewed
Jan 23, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #89 +/- ##
==========================================
- Coverage 88.38% 84.40% -3.99%
==========================================
Files 24 25 +1
Lines 439 468 +29
==========================================
+ Hits 388 395 +7
- Misses 51 73 +22 ☔ View full report in Codecov by Sentry. |
|
@avik-pal What's standing in the way of merging this in? All tests are passing (except Tracker is broken, see above). I'd like to be able to make use of these features in my library once available. |
avik-pal
approved these changes
Feb 6, 2025
…underlying model
….,hcat,eachcol(...))` for compatibility with GPUArrays
…avor of comparing absolute difference with a small threshold
…dices to leave alone.
…e sake of `AutoTracker`
…he two calls to the underlying `model`
…ims` on an empty array. Noted broken Tracker gradient test for `PositiveDefinite`
avik-pal
force-pushed
the
positive-definite-container
branch
from
76e0fe2 to
a5207d2
Compare
|
tests are failing with the latest package versions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
PositiveDefinitecontainer wraps an underlying model and results in a model that returns a postive number whenever the input is nonzero (or not equal to a different point specified when defining the container). This is useful, among other applications, in neural Lyapunov applications.