Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: better default json schemas #1678

Merged
merged 1 commit into from
Oct 4, 2021
Merged

feat: better default json schemas #1678

merged 1 commit into from
Oct 4, 2021

Conversation

abzcoding
Copy link
Member

Description

better json schema defaults

Fixes #1673

How Has This Been Tested?

@ChristianChiarulli
Copy link
Member

only thing to test is to make sure it still works with nlspconfig

@abzcoding
Copy link
Member Author

abzcoding commented Oct 4, 2021 •
edited
Loading

it seems to be fine
Screen Shot 2021-10-04 at 11 32 00 AM

Screen Shot 2021-10-04 at 11 32 26 AM

@kylo252
Copy link
Collaborator

kylo252 commented Oct 4, 2021

Can you try to see if we can skip all the ones from the json-store and let the server automatically download it instead?

Nope, not yet anyway: microsoft/vscode#26289

kylo252
kylo252 requested changes Oct 4, 2021
View reviewed changes
Copy link
Collaborator

@kylo252 kylo252 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only real note is a quick find-and-replace http:// -> https:// for the Github and SchemaStore links.

lua/lsp/providers/jsonls.lua Show resolved Hide resolved
lua/lsp/providers/jsonls.lua Outdated Show resolved Hide resolved
@abzcoding
Copy link
Member Author

@kylo252 just updated the code based on your review

@abzcoding abzcoding merged commit 48472a1 into LunarVim:rolling Oct 4, 2021
@abzcoding abzcoding deleted the feat/json-schemas branch October 24, 2021 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PasiBergman PasiBergman PasiBergman left review comments

@kylo252 kylo252 kylo252 approved these changes

@ChristianChiarulli ChristianChiarulli Awaiting requested review from ChristianChiarulli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: include common json schema
4 participants
@abzcoding @ChristianChiarulli @kylo252 @PasiBergman