Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ppy.osu.Game from 2024.219.0 to 2024.1115.0 #268

Merged
merged 2 commits into from
Nov 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitattributes
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

# Check out with crlf (Windows) line endings
*.sln text eol=crlf
*.csproj text eol=crlf
#*.csproj text eol=crlf
*.cs text diff=csharp eol=crlf
*.resx text eol=crlf
*.vsixmanifest text eol=crlf
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/dotnetcore.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
- name: Unit Tests
run: dotnet test --no-build --no-restore
- name: Upload Artifact
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
with:
name: Hishigata (Dev build)
path: osu.Game.Rulesets.Hishigata/bin/Debug/**/osu.Game.Rulesets.Hishigata.dll
2 changes: 1 addition & 1 deletion osu.Game.Rulesets.Hishigata/Objects/HishigataBonus.cs
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public BonusHitSampleInfo(int volume = 0)
{
}

public override HitSampleInfo With(Optional<string> newName = default, Optional<string> newBank = default, Optional<string?> newSuffix = default, Optional<int> newVolume = default)
public override HitSampleInfo With(Optional<string> newName = default, Optional<string> newBank = default, Optional<string?> newSuffix = default, Optional<int> newVolume = default, Optional<bool> newEditorAutoBank = default)
=> new BonusHitSampleInfo(newVolume.GetOr(Volume));

public bool Equals(BonusHitSampleInfo? other)
Expand Down
30 changes: 15 additions & 15 deletions osu.Game.Rulesets.Hishigata/osu.Game.Rulesets.Hishigata.csproj
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup Label="Project">
<TargetFramework>net8.0</TargetFramework>
<AssemblyTitle>osu.Game.Rulesets.Hishigata</AssemblyTitle>
<OutputType>Library</OutputType>
<PlatformTarget>AnyCPU</PlatformTarget>
<RootNamespace>osu.Game.Rulesets.Hishigata</RootNamespace>
</PropertyGroup>
<PropertyGroup>
<AssemblyName>osu.Game.Rulesets.Hishigata</AssemblyName>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="ppy.osu.Game" Version="2024.219.0"/>
</ItemGroup>
</Project>
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup Label="Project">
<TargetFramework>net8.0</TargetFramework>
<AssemblyTitle>osu.Game.Rulesets.Hishigata</AssemblyTitle>
<OutputType>Library</OutputType>
<PlatformTarget>AnyCPU</PlatformTarget>
<RootNamespace>osu.Game.Rulesets.Hishigata</RootNamespace>
</PropertyGroup>
<PropertyGroup>
<AssemblyName>osu.Game.Rulesets.Hishigata</AssemblyName>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="ppy.osu.Game" Version="2024.1115.0"/>
</ItemGroup>
</Project>
Loading