Add Trustworthy Mod #175
Merged
Add Trustworthy Mod #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LumpBloom7
requested changes
Nov 3, 2022
There was a problem hiding this comment.
Thanks for contributing to Hishigata!
The code looks good overall. Some leftover comments need to be removed.
In addition, a resx file needs to be created in resource for the strings used in TW, since that is where the localised strings are fetched from (also makes the string visible in crowdin).
and delete a couple of unusued commented lines
|
I copied the resx file that was already there for the hidden mod and changed the value, not sure if anything else should be done. |
LumpBloom7
approved these changes
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a mod that disables feign notes.
I had never touched C# before, so I checked https://github.com/taulazer/tau to see how to write mods.
I set the score to 80% because the mod makes the beatmaps easier, but I'm not sure if that's the best multiplier.