Feat(ajax responses): Improved localization handling, error reporting and success messages #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pdating libraries
… client language strings
… und update message
BREAKING CHANGE: ILibraryStorage.getFileStream is now async!
…elated issues where current implementation doesn't conform to the H5P standard
…ation errors when uploading packages
|
The changes turned out to be huge, but now error handling is much improved and the ajax endpoint is more stable and nearly fully tested. This means we now have integration tests of nearly all AJAX endpoints (I didn't test installing libraries from the H5P Hub as we still can't mock downloads from there). I had to change the interface of the library (breaking changes):
The example now also adds i18next to the request object. I think it's good to stay localization library agnostic and leave it to the implementation what library to use. Do you agree, @JPSchellenberg ? @JPSchellenberg you can review now. |
|
I've merged the master |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR closes #44, closes #80 and closes #83. To standardize localization it introduces a dev dependency on i18next (very common npm package) and converts the custom replacement variables (%xyz, @xyz) used so far into more widespread {{xyz}} notation.
Implementations can use any localization library, but must add the property t(...) to the Express req object of the if using the Express adapter. They must also follow the {{...}} notation.