Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make all error messages localizable #80

Closed
sr258 opened this issue Aug 30, 2019 · 1 comment · Fixed by #363
Closed

Make all error messages localizable #80

sr258 opened this issue Aug 30, 2019 · 1 comment · Fixed by #363
Labels
duplicate This issue or pull request already exists H5P-Editor released

Comments

@sr258
Copy link
Member

sr258 commented Aug 30, 2019

All errors in the module should to be localizable, so we have to move from just throwing text errors to using localizable ids.

I suggest throwing a custom error object (e.g. H5pError) on critical errors that contains a (human-readable) error code an associative array with relevant variables. (see #44)
@sr258 sr258 added the duplicate This issue or pull request already exists label Sep 1, 2019
@sr258 sr258 closed this as completed Sep 1, 2019
This was referenced Sep 1, 2019
Closed
Closed
@sr258 sr258 reopened this Sep 1, 2019
@sr258 sr258 added this to the Milestone 2 milestone Dec 1, 2019
@sr258 sr258 mentioned this issue Feb 17, 2020
Merged
@sr258 sr258 closed this as completed in #363 Mar 5, 2020
@JPSchellenberg
Copy link
Member

🎉 This issue has been resolved in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate This issue or pull request already exists H5P-Editor released
Projects
None yet
Milestone
No milestone
2 participants
@JPSchellenberg @sr258